On Tue, Dec 11, 2018 at 10:29:10AM -0500, Chuck Lever wrote: > > > > On Dec 11, 2018, at 9:02 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > > Can we also kill off rpcrdma_memreg_ops now? Indirect calls are > > suprisingly expensive, especially in our post-spectre world, and > > xprtrdma always seemed a little odd with this supper generic > > abstraction. > > Yep, I'm considering replacing those indirect calls. > > However, note that the RPC layer is full of them too, as is the > DMA operations that are used by xprtrdma. I'm not sure it will make > much of a difference. I've posted a series to remove them for the DMA fast path, and every indirect calls adds additional cost.