On 11/28/18 4:05 PM, Chuck Lever wrote: > > >> On Nov 28, 2018, at 4:00 PM, Steve Dickson <SteveD@xxxxxxxxxx> wrote: >> >> >> >> On 11/27/18 11:45 AM, Chuck Lever wrote: >>> Ping! >> My apologies for taking so long to get to this... >> I took an extended Thanksgiving then completely >> for got about it... Thanks for the ping... but :-) >> >> When I enable junctions via --enable-junction I get the >> following compile error with or w/out these patches >> >> gcc -DHAVE_CONFIG_H -I. -I../../support/include -I. -I../../support/include -D_GNU_SOURCE -pipe -Wall -Wextra -Werror=strict-prototypes -Werror=missing-prototypes -Werror=missing-declarations -Werror=format=2 -Werror=undef -Werror=missing-include-dirs -Werror=strict-aliasing=2 -Werror=init-self -Werror=implicit-function-declaration -Werror=return-type -Werror=switch -Werror=overflow -Werror=parentheses -Werror=aggregate-return -Werror=unused-result -fno-strict-aliasing -Werror=format-overflow=2 -Werror=int-conversion -Werror=incompatible-pointer-types -Werror=misleading-indentation -g -O2 -MT remove.o -MD -MP -MF .deps/remove.Tpo -c -o remove.o remove.c >> In file included from lookup.c:31: >> ../../support/include/rpcsvc/nfs_prot.h:9:10: fatal error: rpc/rpc.h: No such file or directory >> #include <rpc/rpc.h> >> ^~~~~~~~~~~ >> I know how to fix it... Add the following to CFLAGS and LDFLAGS >> `pkg-config --cflags libtirpc` >> `pkg-config --libs libtirpc` >> >> First I'm wonder how you got things to compile w/out making these changes > > Well I built and tested this on RHEL 7. If you're testing on > late-model Fedora, you're probably getting a slightly different > build configuration. Just a guess. Fair enough.... > > >> and secondly I'm wondering where we should make these changes... >> >> Maybe we should hardcode the -I/usr/include/tirpc and -ltirpc >> flags in aclocal/libtirpc.m4? > > libtirpc.m4 seems like the right place, but hard-coding seems > like a sledgehammer. Maybe have a look at the changes I made > to libxml2.m4 and do something similar? It turns out that the AM_CPPFLAGS were being overwritten by the nfsref/Makefile.am file... Removing that definition allowed the proper flags and libs to be set... steved.
