On Fri, Oct 26, 2018 at 5:26 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> On Fri, Oct 26, 2018 at 04:10:48PM -0400, Olga Kornievskaia wrote:
> > +++ b/fs/read_write.c
> > @@ -1594,6 +1594,9 @@ ssize_t vfs_copy_file_range(struct file *file_in, loff_t pos_in,
> > }
> > }
> >
> > + if (pos_in >= i_size_read(inode_in))
> > + return -EINVAL;
> > +
> > if (file_out->f_op->copy_file_range) {
> > ret = file_out->f_op->copy_file_range(file_in, pos_in, file_out,
> > pos_out, len, flags);
>
> Is this the right place to check this? Surely we should be checking for
> this before calling clone_file_range()?
Ops, indeed this is the wrong place. If I were to keep this check here
then I need to move it where it was originally located. However, right
now I'm included to not do the check in VFS at all and move it to NFS.
