On Thu, Oct 25, 2018 at 6:17 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > On Thu, Oct 25, 2018 at 05:51:36PM -0400, Olga Kornievskaia wrote: > > +-- > > +[mandatory] > > + ->copy_file_range() may now be passed files which belong to two > > + different superblocks of the same file system type or which belong > > + to two different filesystems types all together. As before, the > > + destination's copy_file_range() is the function which is called. > > + If it cannot copy ranges from the source, it should return -EXDEV. > > Something weird happened to the indentation here? I will recheck my tabs. Thank you. > > > +++ b/Documentation/filesystems/vfs.txt > > @@ -1,5 +1,6 @@ > > > > Overview of the Linux Virtual File System > > +- [fs] nfs: Don't let readdirplus revalidate an inode that was marked as stale (Benjamin Coddington) [1429514 1416532] > > > > Original author: Richard Gooch <rgooch@xxxxxxxxxxxxx> > > > > This stray change slipped in. Wow. Thank you. I have no idea how that got in. Will fix it. > > > @@ -958,7 +959,10 @@ otherwise noted. > > > > fallocate: called by the VFS to preallocate blocks or punch a hole. > > > > - copy_file_range: called by the copy_file_range(2) system call. > > + copy_file_range: called by copy_file_range(2) system call. This method > > + works on two file descriptors that might reside on > > + different superblocks which might belong to file systems > > + of different types. > > I don't think you need this change at all. Ok will remove it. > The actual code looks good. Thank you for the review.
