Hi Trond, I love your patch! Perhaps something to improve: [auto build test WARNING on nfs/linux-next] [also build test WARNING on v4.19-rc5 next-20180924] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Trond-Myklebust/NFSv3-Improve-NFSv3-performance-when-server-returns-no-post-op-attributes/20180925-122432 base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next config: i386-randconfig-x005-201838 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): fs/nfs/nfs3xdr.c: In function 'nfs3_xdr_dec_read3res': >> fs/nfs/nfs3xdr.c:1677:30: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] struct nfs_server *server = result->server; ^~~~~~ fs/nfs/nfs3xdr.c:1678:15: warning: unused variable 'replen' [-Wunused-variable] unsigned int replen, pos; ^~~~~~ fs/nfs/nfs3xdr.c:1677:21: warning: unused variable 'server' [-Wunused-variable] struct nfs_server *server = result->server; ^~~~~~ vim +/const +1677 fs/nfs/nfs3xdr.c 1672 1673 static int nfs3_xdr_dec_read3res(struct rpc_rqst *req, struct xdr_stream *xdr, 1674 void *data) 1675 { 1676 struct nfs_pgio_res *result = data; > 1677 struct nfs_server *server = result->server; 1678 unsigned int replen, pos; 1679 enum nfs_stat status; 1680 int error; 1681 1682 pos = xdr_stream_pos(xdr); 1683 error = decode_nfsstat3(xdr, &status); 1684 if (unlikely(error)) 1685 goto out; 1686 error = decode_post_op_attr(xdr, result->fattr); 1687 if (unlikely(error)) 1688 goto out; 1689 result->op_status = status; 1690 if (status != NFS3_OK) 1691 goto out_status; 1692 result->replen = 3 + ((xdr_stream_pos(xdr) - pos) >> 2); 1693 error = decode_read3resok(xdr, result); 1694 out: 1695 return error; 1696 out_status: 1697 return nfs3_stat_to_errno(status); 1698 } 1699 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
