On Wed, Sep 5, 2018 at 11:12 AM Trond Myklebust <trondmy@xxxxxxxxxxxxxxx> wrote: > > On Wed, 2018-09-05 at 09:44 -0400, Olga Kornievskaia wrote: > > commit 033853325fe3bdc70819a8b97915bd3bca41d3af > > Author: Olga Kornievskaia <kolga@xxxxxxxxxx> > > Date: Wed Mar 8 14:39:15 2017 -0500 > > > > NFSv4.1 respect server's max size in CREATE_SESSION > > > > Currently client doesn't respect max sizes server returns in > > CREATE_SESSION. > > nfs4_session_set_rwsize() gets called and server->rsize, server- > > >wsize are 0 > > so they never get set to the sizes returned by the server. > > > > Signed-off-by: Olga Kornievskaia <kolga@xxxxxxxxxx> > > Signed-off-by: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx> > > > > Olga, I'm confused by that patch. It appears to assume that we should > be using the CREATE_SESSION, request/response limits as default values > instead of as limits? > > AFAICS, the real problem there is that nfs4_server_common_setup() is > calling nfs4_session_set_rwsize() before we actually set the r/wsize in > the call to nfs_probe_fsinfo(). No? I didn't know that nfs_probe_fsinfo() set the server->r/wsize. I thought it was only set in nfs4_session_set_rwsize() to the values from the session attributes.
