finally getting back to this... On Wed, Aug 22, 2018 at 9:47 PM J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote: > > On Thu, Aug 09, 2018 at 04:34:50PM -0400, J. Bruce Fields wrote: > > Thanks, I've added these to my -next branch, and I want to read through > > them tomorrow. > > Gah, I screwed up and took to long to get around to this and have a few > things I'd like to change, so I'm going to queue these up again for > 4.20. > > The way the patches are broken up doesn't really work; for example > init_cp_state is used in one but patch not defined till a later patch, I don't see what you are seeing.. init_cp_state is defined and used in 0006-NFSD-create-new-stateid-for-async-copy.patch > and waiting till the last patch to cleanup on client expiry leaves us That's correct the whole 'stopping threads' it sorta tied in with the signaling that OFFLOAD_CANCEL also uses. > with a bug until that patch is applied. I'm not seeing a better way to > split things up so I think best is just to glom them all together, which > I've gone ahead and done. (The XDR patches are still separate, I'm not > sure how much that helps but I think it's harmless.) If you are ok with a single patch for the whole async feature, that's fine with me. > I'm not sure about the signalling--I don't see anything else outside > core code setting TIF_SIGPENDING directly, is that really all we need to > do? > I know it was me that asked for signalling there, but for now let's > just rely on kthread_stop. If somebody can explain to me how we're > supposed to do the signalling, we can do that, but then we should rely > on it alone and not do both that and kthread_stop. The modified code seems to work. I think I had signal_pending() in case something else in the kernel was doing something and sending us the TIF_SIGPENDING signal. As for setting it, that was an overkill since I was already doing kthread_stop(). > That's a minor change so I did that as well, hope that's OK. Results > are in my linux-next branch. I'm also happy to look at the > server-to-server patches on top of that if they're ready. > > --b.
