> On Sep 1, 2018, at 2:07 AM, Frank Sorenson <sorenson@xxxxxxxxxx> wrote:
>
> If nsm_insert_monitored_host() fails while saving the record to
> stable storage, we can't just assume the entry was new. Existing
> records must be removed from the list before being freed.
>
> Signed-off-by: Frank Sorenson <sorenson@xxxxxxxxxx>
Reviewed-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
> diff --git a/utils/statd/monitor.c b/utils/statd/monitor.c
> index 45c4346..9400048 100644
> --- a/utils/statd/monitor.c
> +++ b/utils/statd/monitor.c
> @@ -197,7 +197,7 @@ sm_mon_1_svc(struct mon *argp, struct svc_req *rqstp)
>
> if (!nsm_insert_monitored_host(dnsname,
> (struct sockaddr *)(char *)&my_addr, argp)) {
> - nlist_free(NULL, clnt);
> + nlist_free(existing ? &rtnl : NULL, clnt);
> goto failure;
> }
>
--
Chuck Lever
