Re: [PATCH v2] NFSv4: bump/drop the nlink count on the parent dir when we mkdir/rmdir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Trond,

I love your patch! Yet something to improve:

[auto build test ERROR on nfs/linux-next]
[also build test ERROR on v4.18-rc7 next-20180727]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Trond-Myklebust/NFSv4-bump-drop-the-nlink-count-on-the-parent-dir-when-we-mkdir-rmdir/20180730-123301
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: i386-randconfig-a1-201830 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   fs/nfs/nfs4proc.c: In function 'nfs4_dec_nlink_locked':
>> fs/nfs/nfs4proc.c:1085:2: error: implicit declaration of function 'dec_nlink' [-Werror=implicit-function-declaration]
     dec_nlink(inode);
     ^
   cc1: some warnings being treated as errors

vim +/dec_nlink +1085 fs/nfs/nfs4proc.c

  1080	
  1081	static void
  1082	nfs4_dec_nlink_locked(struct inode *inode)
  1083	{
  1084		NFS_I(inode)->cache_validity |= NFS_INO_INVALID_OTHER;
> 1085		dec_nlink(inode);
  1086	}
  1087	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux