On Thu, Jul 12, 2018 at 03:16:45PM -0400, J. Bruce Fields wrote: > On Thu, Jul 12, 2018 at 03:11:14PM -0400, Olga Kornievskaia wrote: > > On Thu, Jul 12, 2018 at 2:56 PM, J. Bruce Fields <bfields@xxxxxxxxxx> wrote: > > > I think we got confused in the previous discussion of this. > > > > > > The reason I wanted the module parameter was that server-to-server copy > > > would allow a rogue client to direct the server to copy from any server > > > it wishes, and I thought this was potentially risky, and want people to > > > opt into it rather than having it the default. > > > > > > That doesn't apply to asynchronous copy on its own. > > > > > > So this module parameter could wait for the next patchset. > > > > To clarify, you want "inter" copy offload to be configuration, but it > > already was (when it was first posted) under config option. Now > > instead of a compile option you prefer this to be a module parameter? > > That's right. > > I'd like distributions to be able to include server-to-server-copy > capable kernels, but I don't want it on by default because I think > responsible administrators will want to do some firewalling first. > > > Do you have any other comments? I'd rather not re-post another version > > if you have more comments. > > In that case I'd recommend holding off till next week. I read through the rest of the patches and don't see any show stoppers. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html