Re: [PATCH nfs-utils] mount: handle ENOSPC in nfs_autonegotiate()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 06/21/2018 12:59 PM, Trond Myklebust wrote:
> On Thu, 2018-06-21 at 09:34 -0700, Manjunath Patil wrote:
>> The server may return NFS4ERR_NOSPC during NFSv4.1+ mount if there is
>> a
>> memory pressure to allocate a DRC slot for session being created. In
>> such cases, try with lower nfs versions, which may succeed as DRC is
>> shared by clients.
>>
>> Signed-off-by: Manjunath Patil <manjunath.b.patil@xxxxxxxxxx>
>> ---
>>  utils/mount/stropts.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
>> index d1b0708..7e97a88 100644
>> --- a/utils/mount/stropts.c
>> +++ b/utils/mount/stropts.c
>> @@ -881,6 +881,10 @@ check_result:
>>  	case EINVAL:
>>  		/* A less clear indication that our client
>>  		 * does not support NFSv4 minor version. */
>> +	case ENOSPC:
>> +		/* Server returned NFS4ERR_NOSPC for create session
>> [NFSv4.1+].
>> +		 * Try with lower NFS versions which share DRC
>> amoung clients and
>> +		 * hence low memory may be ok. */
>>  	case EACCES:
>>  		/* An unclear indication that the server
>>  		 * may not support NFSv4 minor version. */
> 
> This comment makes no sense. NFSv4.1 servers also share memory between
> clients, and unlike older versions of NFS, they have ways to reclaim
> that memory (see CB_RECALL_SLOT).
> 
So this is a NACK to this patch... just to make it official

steved.
 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux