Re: [PATCH v1 2/2] NFSv4.0: Remove transport protocol name from non-UCS client ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2018-06-06 at 11:48 -0400, Chuck Lever wrote:
> > On Jun 6, 2018, at 11:44 AM, Trond Myklebust <trondmy@hammerspace.c
> > om> wrote:
> > 
> > On Mon, 2018-06-04 at 10:53 -0400, Chuck Lever wrote:
> > > Commit 69dd716c5ffd ("NFSv4: Add socket proto argument to
> > > setclientid") (2007) added the transport protocol name to the
> > > client
> > > ID string, but the patch description doesn't explain why this was
> > > necessary.
> > > 
> > > At that time, the only transport protocol name that would have
> > > been
> > > used is "tcp" (for both IPv4 and IPv6), resulting in no
> > > additional
> > > distinctiveness of the client ID string.
> > > 
> > > Since there is one client instance, the server should recognize
> > > it's
> > > state whether the client is connecting via TCP or RDMA. Same
> > > client,
> > > same lease.
> > 
> > The reason why this is the case now is because the trunking code
> > overrides the guardrails in nfs_get_client(). The latter does match
> > on
> > the protocol.
> 
> OK. Would that also true in the UCS case?
> 

Yes, I believe that code is independent of the migration flag.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@xxxxxxxxxxxxxxx

��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux