Re: [PATCH 4/5] NFS: Pass "privileged" value to nfs4_call_sync()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2018-05-04 at 16:22 -0400, schumaker.anna@xxxxxxxxx wrote:
> From: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx>
> 
> This lets us convert a few other users of synchronous RPC calls to
> the
> nfs4_call_sync() function.
> 
> Signed-off-by: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx>
> ---
>  fs/nfs/nfs42proc.c |  8 ++---
>  fs/nfs/nfs4_fs.h   |  2 +-
>  fs/nfs/nfs4proc.c  | 78 ++++++++++++++++++++++--------------------
> ----
>  3 files changed, 42 insertions(+), 46 deletions(-)
> 
> diff --git a/fs/nfs/nfs42proc.c b/fs/nfs/nfs42proc.c
> index 4d4a3df28779..7e9a208940e2 100644
> --- a/fs/nfs/nfs42proc.c
> +++ b/fs/nfs/nfs42proc.c
> @@ -47,7 +47,7 @@ static int _nfs42_proc_fallocate(struct rpc_message
> *msg, struct file *filep,
>  		return -ENOMEM;
>  
>  	status = nfs4_call_sync(server->client, server, msg,
> -				&args.seq_args, &res.seq_res, 0);
> +				&args.seq_args, &res.seq_res, 0, 0);

This is getting overly complicated. Note that the common case users are
all setting the new argument to '0'.

I'm happier if we let the privileged calls stand out, so that we can
distinguish them from the crowd.

-- 
Trond Myklebust
CTO, Hammerspace Inc
4300 El Camino Real, Suite 105
Los Altos, CA 94022
www.hammer.space id="-x-evo-selection-end-marker">��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux