On Tue, Apr 24, 2018 at 04:10:29PM -0400, Olga Kornievskaia wrote: > Do you by any chance have a reference to this discussion? This: http://lkml.kernel.org/r/1507740502-5151-1-git-send-email-Thomas.Haynes@xxxxxxxxxxxxxxx and this: http://lkml.kernel.org/r/E0161195-9F4A-4B36-A71D-6A924498C893@xxxxxxxxxxxxxxx and followups. > I would like to reference it. For now I'm hijacking this thread to > bring this up. I'm still concerned about the case where client sent a > request and slot got interrupted (so by default the client doesn't > increment the seq#). Then the client re-used the slot for the same > kind of operation (WRITE is very interesting) with same arguments but > say different FH. Is the server obligated the cache the whole call to > address and check that? You have a patch to check for false retries > that checks for different creds but I don't think you have something > that would catch this case? Right. I don't believe the spec requires us to catch false retries in every possible case. That may mean we return a pretty bizarre reply that doesn't match the request, but that's the client's own fault.... --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
