On Tue, Mar 13, 2018 at 11:44:37AM -0400, Chuck Lever wrote: > TP_fast_assign( > __entry->xid = be32_to_cpu(rqstp->rq_xid); > - do { > - struct knfsd_fh fh; > - > - fh_copy_shallow(&fh, &fhp->fh_handle); > - __entry->fh_hash = knfsd_fh_hash(&fh); > - } while (0); > + __entry->fh_hash = knfsd_fh_hash(&fhp->fh_handle); > __entry->offset = offset; > __entry->len = len; > ), What's that about? Why did someone originally think we needed to copy before hashing? --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html