Re: [PATCH 12/23] NFS/SUNRPC: don't lookup machine credential until rpcauth_bindcred().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi NeilBrown,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on nfs/linux-next]
[also build test WARNING on v4.16-rc2 next-20180219]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/NeilBrown/Remove-generic-rpc-credentials-and-associated-changed-V3/20180219-190836
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> net/sunrpc/auth.c:700:34: sparse: incorrect type in initializer (different address spaces) @@ expected struct cred const @@ got struct cred const [addrestruct cred const @@
   net/sunrpc/auth.c:700:34: expected struct cred const
   net/sunrpc/auth.c:700:34: got struct cred const cred

vim +700 net/sunrpc/auth.c

   693	
   694	static struct rpc_cred *
   695	rpcauth_bind_machine_cred(struct rpc_task *task, int lookupflags)
   696	{
   697		struct rpc_auth *auth = task->tk_client->cl_auth;
   698		struct auth_cred acred = {
   699			.principal = task->tk_client->cl_principal,
 > 700			.cred = init_task.cred,
   701		};
   702	
   703		if (!acred.principal)
   704			return NULL;
   705		dprintk("RPC: %5u looking up %s machine cred\n",
   706			task->tk_pid, task->tk_client->cl_auth->au_ops->au_name);
   707		return auth->au_ops->lookup_cred(auth, &acred, lookupflags);
   708	}
   709	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux