On Thu, 2018-01-18 at 09:26 -0500, Chuck Lever wrote: > > > On Jan 18, 2018, at 4:28 AM, Justin Mitchell <jumitche@xxxxxxxxxx> wrote: > > > > On Wed, 2018-01-17 at 17:10 -0500, Chuck Lever wrote: > >> This file is not part of "git clone" and is not #included from any > >> C file. > >> > >> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> > >> --- > >> support/nfsidmap/Makefile.am | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> Hey Steve- > >> > >> I don't see nfsidmap_internal.h anywhere. Wondering if I missed > >> something? > > > > It was removed as part of my ABI cleanup (commit f080188e) to stop > > libnfsidmap from leaking all sorts of private symbols. > > > > Some of it went to libnfsidmap_plugin.h and some to > > libnfsidmap_private.h > > > > Some external packages which offered libnfsidmap plugins were using > > these undocumented symbols by copying libnfsidmap_internal.h, so i > > reworked the neccessary parts into an API as libnfsidmap_plugin.h and > > hid the rest. > > > > I clearly missed this reference to the file as it didn't generate any > > warnings for me, sorry about that. > > No apologies needed. Are you confirming that this clean up is OK? > Can I get an amen? (I mean, can I get a Reviewed-by?) > > > -- > Chuck Lever > Yes, all looks good. thanks Reviewed-by: Justin Mitchell <jumitche@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
