Re: backchannel tracepoint expects rpc_clnt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16 Jan 2018, at 10:31, Benjamin Coddington wrote:

Hi Trond,

I'm trying to get to the bottom of a backchannel problem, but with
tracepoints enabled things blow up in trace_rpc_task_sleep() because there's
no rpc_clnt (or easy way to get to one) on a backchannel request.

The only reason we're sending the rpc_clnt to that tracepoint is to emit the
cl_clid:

commit 2f048db4680ae19da13df15d352ac02748781ecb
Author: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
Date:   Wed Sep 4 21:51:44 2013 -0400

    SUNRPC: Add an identifier for struct rpc_clnt

    Add an identifier in order to aid debugging.

Can we rather just use the address of the struct rpc_clnt rather than an
integer in the tracepoint?

Well, I suppose we can just do it the same way trace_rpc_task_running() does
it, which is with:

89     TP_fast_assign(
90         __entry->client_id = clnt ? clnt->cl_clid : -1;

I'll send a patch for that..

Ben
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux