On Thu, 11 Jan 2018, Trond Myklebust wrote: > On Thu, 2018-01-11 at 08:10 -0500, Scott Mayhew wrote: > > Trond, Anna, > > > > Any concerns with this patch? > > > > We left this run on multiple machines through the holidays... all > > doing > > direct I/O to a Netapp filer while doing storage failovers on an > > hourly > > basis on the filer. No more issues with processes getting stuck in > > inode_dio_wait. > > I'm fine with this version. Should it be a stable fix? If so, do we > have a "Fixes:" commit for it? Yeah it should probably be a stable fix. The hdr->release() call was added in commit 1ca018d28d ("pNFS: Fix a memory leak when attempted pnfs fails")... but I can reproduce this on earlier kernels than that (I tested 4.0) so it looks like this goes way back... -Scott > > -- > Trond Myklebust > Linux NFS client maintainer, PrimaryData > trond.myklebust@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html