On Mon, Dec 11, 2017 at 8:04 AM, NeilBrown <neilb@xxxxxxxx> wrote: > A file handle buffer is not tiny, and could need to be larger in future, > so it isn't safe to allocate one on the stack. Instead, we need to > kmalloc(). > > There is no way to return an error status from a ->show_fdinfo() > function, so if the kmalloc fails, we silently exclude the filehandle > from the output. As it is at the end of line, this shouldn't > upset parsing too much. I think that is a bold assumption to make about parsers ;) Anyway, the second reasoning is stronger, so may as well drop this one. There is probably a single userspace user for this which is CRIU, for which this fdinfo file handle was added, so you could possibly say that this change does not upset this user (?). > In any case, it can only fail when the > process is being killed by the OOM killer, so the file will never > be parsed anyway. > > Signed-off-by: NeilBrown <neilb@xxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
