Re: [PATCH v6 05/10] NFSv4: Retry CLOSE and DELEGRETURN on NFS4ERR_OLD_STATEID.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2017-11-05 at 21:46 -0500, Andrew W Elble wrote:
> I've been testing these a bit, I think this was causing an issue...
> 
> Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> writes:
> 
> > diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
> > index d615b7cdfa8f..752b18e88266 100644
> > --- a/fs/nfs/nfs4state.c
> > +++ b/fs/nfs/nfs4state.c
> > @@ -986,6 +986,22 @@ static int nfs4_copy_lock_stateid(nfs4_stateid
> > *dst,
> >  	return ret;
> >  }
> >  
> > +bool nfs4_refresh_open_stateid(nfs4_stateid *dst, struct
> > nfs4_state *state)
> > +{
> > +	bool ret;
> > +	int seq;
> > +
> > +	do {
> > +		ret = false;
> > +		seq = read_seqbegin(&state->seqlock);
> > +		if (nfs4_state_match_open_stateid_other(state,
> > dst)) {
> > +			dst->seqid = state->stateid.seqid;
> 
> You mean:
> 
>                         dst->seqid = state->open_stateid.seqid;
> 

Doh! Yes, that's entirely correct... Thanks for the review and for
spotting that!

-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@xxxxxxxxxxxxxxx
��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux