On Fri, 2017-11-03 at 10:05 -0400, Andrew Elble wrote:
>
> DELEGRETURN has also been
> optimized to return NFS4_OK when called with a revoked delegation.
Hmm.... I missed this in the original patch, and I'm not sure that it
is a good idea.
This would be going back to the issues that Olga and I discussed a
while ago concerning lock recovery. Since the LOCK operation does not
take a delegation stateid, we cannot know for sure that the recovered
lock was protected by the delegation until we send the DELEGRETURN, and
get either NFS_OK or NFS4ERR_DELEG_REVOKED.
We could, in theory, add a TEST_STATEID for the delegation stateid in
the same COMPOUND immediately after the LOCK operation in order to get
the NFS4ERR_DELEG_REVOKED assurance at an earlier time, but that only
works for NFSv4.1 and newer.
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@xxxxxxxxxxxxxxx
��.n��������+%������w��{.n�����{��w��� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
