On Tue, 2017-10-31 at 18:33 -0400, Andrew W Elble wrote:
> Not directly related to this patch series, but:
>
> I keep staring at the failure path in nfsd4_process_open2() from the
> call to nfs4_get_vfs_file() and thinking that there's a missing state
> change to the stateid that's still hashed before the mutex is dropped
> and the call to release_open_stateid()?
>
If the seqid==1, so that we know this OPEN op created that stateid,
then it probably should be unhashed and marked as closed, since then we
know it represents no state. Otherwise, AFAICS it should keep its
current state + seqid.
Do you want to send a patch, or should I update this patch series? Such
a fix probably does want to be a stable patch, since it will affect
clients that expect compliance with RFC5661/RFC7530.
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@xxxxxxxxxxxxxxx
��.n��������+%������w��{.n�����{��w��� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
