We know that the socket autoclose cannot be queued after we've set the XPRT_LOCKED bit, so the call to cancel_work_sync() is redundant. In addition, it is causing lockdep to complain about a false ABA lock dependency. Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> --- net/sunrpc/xprt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c index e741ec2b4d8e..5f12fe145f02 100644 --- a/net/sunrpc/xprt.c +++ b/net/sunrpc/xprt.c @@ -1464,7 +1464,6 @@ static void xprt_destroy(struct rpc_xprt *xprt) rpc_destroy_wait_queue(&xprt->pending); rpc_destroy_wait_queue(&xprt->sending); rpc_destroy_wait_queue(&xprt->backlog); - cancel_work_sync(&xprt->task_cleanup); kfree(xprt->servername); /* * Tear down transport state and free the rpc_xprt -- 2.13.6 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
