Re: [RFC v3 25/42] NFSD add COPY_NOTIFY operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 13, 2017 at 10:38:46AM -0400, Olga Kornievskaia wrote:
> On Wed, Sep 6, 2017 at 5:37 PM, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote:
> > On Tue, Jul 11, 2017 at 12:43:59PM -0400, Olga Kornievskaia wrote:
> >> +struct nfsd4_copy_notify {
> >> +     /* request */
> >> +     stateid_t               cpn_src_stateid;
> >> +     struct nl4_server       cpn_dst;
> >> +
> >> +     /* response */
> >> +     /* Note: cpn_src_stateid is used for cnr_stateid */
> >
> > That might be worth a little more explanation.
> 
> I'm opting for removing it from this patch? It's just valid for that
> patch saying that for the
> moment the same cpn_src_stateid is returned fort he cnr_stateid in the
> later patch (29)
> we will add the generation of the unique stateid used for the copy.

Got it, yes, that did confuse me, dropping the comment and noting the
coming change in the changelog would be great.--b.

> 
> >
> > --b.
> >
> >> +     u64                     cpn_sec;
> >> +     u32                     cpn_nsec;
> >> +     struct nl4_servers      cpn_src;
> >> +};
> >> +
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux