> On Sep 5, 2017, at 6:03 PM, Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Sep 05, 2017 at 05:22:04PM -0400, Chuck Lever wrote: >> >>> On Sep 5, 2017, at 4:06 PM, Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> wrote: >>> >>> On Tue, Sep 05, 2017 at 01:00:10PM -0400, Chuck Lever wrote: >>> >>>> - Send completions are batched to reduce interrupts, but still >>>> provide a periodic heartbeat signal for SQ housekeeping >>> >>> I would scrub this commentary, it is very misleading. >>> >>> The idea of a periodic completion does not match how verbs works at >>> all, it was an incomplete root cause analysis from a HCA that uses >>> different rules for freeing space in the SQ. >> >> I think it does bear mentioning that, given this diagnosis, it is >> still safe to remove the ib_post_send counting mechanism in 5/5, >> which has been in xprtrdma for as long as I can recall, and has >> been effective (with a few minor adjustments) at preventing SQ >> overflow. > > Sure, but lets just talk about it in the context of ensuing the SQ > does not go full, and not some nebulous idea of heartbeat. > > The new approach directly prevents overflow, and the past failings in > NFS all boiled down to stuffing SQEs into a full SQ, as some NICs do > not 'empty' the SQ until the CQ is generated. Understood. There are one or two code comments introduced by this series that will need to be similarly adjusted. >> I'm not able to test this change with every HCA the Linux kernel >> currently supports, unfortunately. The best I can do is offer a >> "proof of correctness" and hope that vendors will jump on this >> and try it out. > > Assuming it is implemented properly in NFS, any HCA that fails with > this is broken by definition.. A HCA must work correctly if the SQ is > full, and all but the last entry are unsignaled. > > Jason -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
