> On Aug 30, 2017, at 8:15 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Wed, Aug 30, 2017 at 12:51:06PM +0100, Justin Mitchell wrote: >> Moving the config parsing code out to a shared library fixes both >> of these issues with minimal code changes. I appreciate that the >> API this library presents is less than ideal, it was left this way >> to reduce code changes at this point, and i welcome suggestions for >> a sympathetic approach to improving it. > > The general shard code approach look good, but is there any good > reason not to merge libnfsidmap into nfs-utils and make it a > static (or at least a private shared) library instead of introducing > a new ABI? Agreed: who else is using libnfsidmap? Is there currently a packaging requirement that keeps it outside of nfs-utils? -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html