Re: [RFC v3 2/2] SUNRPC: Mask XIDs to prevent replay cache collision

[NeilBrown <neilb@xxxxxxxx>]

On Tue, Aug 15 2017, Bennett Amodio wrote:
>
>   for (i = 0; i < args->nconnect - 1; i++) {
> +     xprtargs.transport_id += 1;
>       if (rpc_clnt_add_xprt(clnt, &xprtargs, NULL, NULL) < 0)
>           break;
>   }

hi,
 this is a tiny point, but I think this code would look nicer as

   for (i = 1; i < args->nconnect; i++) {
           xprtargs.transport_id = i;
           if (rpc_clnt_add_xprt(clnt, &xprtargs, NULL, NULL) < 0)
                   break;
   }

Thanks,
NeilBrown

Attachment: signature.asc
Description: PGP signature