Re: [RFC v3 14/42] NFS if we got partial copy ignore errors

[Olga Kornievskaia <kolga@xxxxxxxxxx>]

> On Jul 12, 2017, at 10:52 AM, Anna Schumaker <schumaker.anna@xxxxxxxxx> wrote:
> 
> Hi Olga,
> 
> On 07/11/2017 12:43 PM, Olga Kornievskaia wrote:
>> Signed-off-by: Olga Kornievskaia <kolga@xxxxxxxxxx>
>> ---
>> fs/nfs/nfs42proc.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/fs/nfs/nfs42proc.c b/fs/nfs/nfs42proc.c
>> index dba2b62..dfd43bc 100644
>> --- a/fs/nfs/nfs42proc.c
>> +++ b/fs/nfs/nfs42proc.c
>> @@ -179,7 +179,8 @@ static int handle_async_copy(struct nfs42_copy_res *res,
>> out:
>> 	*ret_count = copy->count;
>> 	memcpy(&res->write_res.verifier, &copy->verf, sizeof(copy->verf));
>> -	status = -copy->error;
>> +	if (copy->count <= 0)
>> +		status = -copy->error;
> 
> This is a pretty small change.  Can you squash this patch into patch 8
> ("NFS add support for asynchronous COPY") that way the code is correct from
> the time it's added?

Ok.

> 
> Thanks,
> Anna
> 
>> 
>> 	kfree(copy);
>> 	return status;
>> 

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html