Re: [RFC v3 01/42] fs: Don't copy beyond the end of the file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Olga,

On 07/11/2017 12:43 PM, Olga Kornievskaia wrote:
> From: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx>
> 
> Signed-off-by: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx>

Would it make sense to submit this patch to the VFS in the same series as the cross mountpoint patch, that way they both go in at once?  This one should really be able to go in now, rather than waiting for the rest of the series.

Thanks,
Anna

> ---
>  fs/read_write.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/read_write.c b/fs/read_write.c
> index 19d4d88..cc2618b 100644
> --- a/fs/read_write.c
> +++ b/fs/read_write.c
> @@ -1584,6 +1584,9 @@ ssize_t vfs_copy_file_range(struct file *file_in, loff_t pos_in,
>  	if (unlikely(ret))
>  		return ret;
>  
> +	if (pos_in >= i_size_read(inode_in))
> +		return -EINVAL;
> +
>  	if (!(file_in->f_mode & FMODE_READ) ||
>  	    !(file_out->f_mode & FMODE_WRITE) ||
>  	    (file_out->f_flags & O_APPEND))
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux