On 15 Jun 2017, at 16:34, Jeff Layton wrote: > Yeah, I think a smp_wmb() there, paired with the implied barrier in the > atomic_dec_and_test in rpc_put_task? Yes, that should do it. >>>> No need for a whole int for a flag and these do get allocated. Make >>>> it a >>>> bool? >> >> or >> >> unsigned int : 1 >> >> which seems to be often used -- see nfs4_opendata. The cancelled flag >> could >> be changed there as well I suppose. > > I'd prefer a bool, but it's really up to Trond and Anna, I suppose. If Anna or Trond will tell us how they'd like it, I can follow up with a patch to make them all consistent. Ben -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
