> On Jun 6, 2017, at 5:02 PM, Steve Dickson <SteveD@xxxxxxxxxx> wrote:
>
>
>
> On 06/06/2017 03:52 PM, Chuck Lever wrote:
>>
>>> On Jun 6, 2017, at 3:48 PM, Steve Dickson <steved@xxxxxxxxxx> wrote:
>>>
>>> When the nfs4 filesystem specified, the default minor
>>> version should be used not v4.0.
>>
>> Isn't the default specified in the mountnfs config file?
> It can be... But in general its not...
>
> So the question is when the nfs4 file system (aka -t nfs4)
> what minor version does that mean? v4.0 which was the
> default in the past or the new default v4.2?
IMO the admin (and the distributor) should be allowed to
decide which minorversion is the default for vers=4 or
"-t nfs4".
NFSv4.0 is a safe default for now, so I'm just arguing for
taking a little more time to make this change to minor
version 2 using the config file instead of hard coding it.
No strong opinion, I just think it makes better sense to
handle default minor version the way many other default
behaviors are configured.
> steved.
>>
>>
>>> Signed-off-by: Steve Dickson <steved@xxxxxxxxxx>
>>> ---
>>> utils/mount/stropts.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
>>> index c0266e5..57efb26 100644
>>> --- a/utils/mount/stropts.c
>>> +++ b/utils/mount/stropts.c
>>> @@ -317,7 +317,8 @@ static int nfs_set_version(struct nfsmount_info *mi)
>>>
>>> if (strncmp(mi->type, "nfs4", 4) == 0) {
>>> mi->version.major = 4;
>>> - mi->version.v_mode = V_GENERAL;
>>> + mi->version.minor = 2;
>>> + mi->version.v_mode = V_SPECIFIC;
>>> }
>>> /*
>>> * Before 2.6.32, the kernel NFS client didn't
>>> --
>>> 2.9.4
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
>>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>> --
>> Chuck Lever
>>
>>
>>
--
Chuck Lever
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
