On Wed, May 31 2017, Steve Dickson wrote: > Sorry for the delayed response... that damn > flux capacitor broke... again! ;-) That's what you get for buying it on e-bay?? >> >> According to the extra comments you have added for the modes: >> >>>>> + V_GENERAL, /* single digit => 4 */ >>>>> + V_SPECIFIC, /* single digit < 4 or decimal included */ >> >> And it seems to me that "v4" should be V_GENERAL, not V_SPECIFIC. >> So I think the current code is correct. > Personally I don't see a needed for V_GENERAL v_mode type > I guess it has to do with the specifying minor version or not > but if any thing is specified on the command line or > nfsmount.conf then it is V_SPECIFIC... IMHO. Maybe V_GENERAL should be V_MAJOR or V_SPECIFIC_MAJOR. The v4 code assumes that if V_SPECIFIC is set, then the version option provided to the mount command can be passed unchanged to the kernel. So it sometimes means V_NO_NEGOTIATE. >> I haven't even compile-tested of course :-) > I have and it does compile and work... Would you > mind reposting the patch in the proper format? > You can added Tested-by: Steve Dickson <steved@xxxxxxxxxx> Done. > > Note: The second patch should probably use V_GENERAL as well. Yes, definitely. Thanks, NeilBrown
Attachment:
signature.asc
Description: PGP signature
