On Fri, May 12, 2017 at 08:14:03PM +0000, Trond Myklebust wrote: > On Fri, 2017-05-12 at 18:16 +0200, Christoph Hellwig wrote: > > This series was inspired by two recent events: talking to a academic > > researcher about the harm of function pointer casts for static > > analysis > > at a conference, and reading up the whole Grsecurity drama, including > > finding that their patchset does a lot of work to remove these casts > > in sunrpc and nfs (and in fact those seem the biggest culprit in the > > kernel), and constifying the operation vectors like so many others in > > the kernel, although done in a rather hacky and/or mechnical way. > > > > Note that the first part of the series is about the RPC forechannel, > > and the latter about the backchannel, but due to bidirection > > operation > > in NFSv4 there is no really clean split between the client and server > > parts. > > > > Changes from RFC: > > - move procedure call counters into separate arrays > > > > How should we proceed to merge this series? Given that it is changing a > lot of function headers, but not actually changing functionality, might > it be possible to merge it out-of-band with the merge window (e.g. next > week) in order to minimise the amount of work needed to fix up future > patches? That'd be OK. Or we could commit to a common tree and build on that. Also, whatever we do with the rest, the following appear to be completely independent and touch nothing outside fs/nfsd, I could take them: [PATCH 26/33] nfsd4: properly type op_set_currentstateid callbacks [PATCH 27/33] nfsd4: properly type op_get_currentstateid callbacks [PATCH 28/33] nfsd4: remove nfsd4op_rsize [PATCH 29/33] nfsd4: properly type op_func callbacks [PATCH 33/33] nfsd4: const-ify nfsd4_ops --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
