Re: [PATCH 2/2] NFSv4: Fix callback server shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2017-04-27 at 11:06 +0800, Kinglong Mee wrote:
> 
> There is only one use of svc_set_num_threads that by nfsd,
> I'd like to change svc_set_num_threads and update nfsd than add a new
> function.

You can't really combine the two methods. Either you choose signals or
you choose kthread_stop(). The problem is that signals require the
thread to be able to persist past the nfsd_destroy() (which again
forces things like nfsd() having to take nfsd_mutex), or you have to
make things synchronous, in which case having nfsd() try to take
nfsd_mutex causes deadlocks.

IOW: if there is legacy behaviour here that requires the signal method,
then knfsd cannot be converted.

> Ps,
> "NFSv4.x/callback: Create the callback service through
> svc_create_pooled"
> must be include before the fix. I will resend it later.
> 
OK. Thanks!

-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@xxxxxxxxxxxxxxx
��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux