Re: RFC: fixing kernel oops on interrupted COMMIT from nfs_commit_file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2017-04-14 at 11:56 -0400, Olga Kornievskaia wrote:
> On Thu, Apr 13, 2017 at 4:50 PM, Trond Myklebust
> <trondmy@xxxxxxxxxxxxxxx> wrote:
> > 
> > Secondly, if you want to release the request and you are not sure
> > whether or not it got cleared off the inode's cinfo commit list
> > yet,
> > you may also need to lock that request and call
> > nfs_clear_request_commit().
> 
> Looking at what the function does, I don't see why this is needed.
> "wb_page" is NULL for this type of commit and there is no pnfs in
> this
> case.

Something needs to ensure that the request is not sitting on a commit
list. That can happen if the commit succeeded, but returned a different
verifier, or it can happen if nfs_scan_commit() exits early.

-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@xxxxxxxxxxxxxxx
��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux