On Mon, Apr 03, 2017 at 12:15:55PM +1000, NeilBrown wrote: > On Fri, Mar 31 2017, J. Bruce Fields wrote: > > > On Thu, Mar 30, 2017 at 05:50:47PM +1100, NeilBrown wrote: > >> On Wed, Mar 29 2017, J. Bruce Fields wrote: > >> > >> > Thanks, applying for 4.12.--b. > >> > >> Ugh... does strdup_if_nonnull() actually help readability at all? > >> kstrdup() already handles NULL fine, which is what the name seems to > >> suggest is happening. > >> I would think kstrdup_report_error() is a name that better reflects the > >> function. > >> > >> Or just discard it: > > > > Yes, what was I thinking? Just didn't read kstrdup(), I guess. > > Applying as follows. > > > Thanks. > Feel free to add > Signed-off-by: NeilBrown <neilb@xxxxxxxx> > > I probably should have stuck that in there in the first place, just in > case. For a small patch from a known contributor I figure the risk of just assuming DCO case (c) is negligible. Anyway, added, thanks. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html