svc_rdma_build_send_wr(ctxt, 1); ret = svc_rdma_send(rdma, &ctxt->send_wr); if (ret) { + svc_rdma_unmap_dma(ctxt); + svc_rdma_put_context(ctxt, 1); ret = -EIO; - goto out_unmap; }
Any specific reason to not go with the goto scheme? Can't this function grow more error paths in the future? btw, I'm assuming svc_rdma_unmap_dma() is the opposite of svc_rdma_map_reply_hdr() ? -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html