Re: [PATCH v5 0/5] Add copy_file_range() tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 17, 2017 at 03:02:46PM -0700, Darrick J. Wong wrote:
> On Fri, Mar 17, 2017 at 03:52:28PM -0400, Anna Schumaker wrote:
> > These tests exercise the copy_file_range() system call, and check copying
> > data to both a new file and overwriting data inside an existing file.
> > 
> > Sorry it took so long to get this version out.  I forgot about these patches
> > after the last submission.
> 
> Hooray, tests finally!
> 
> I had to bump the numbers up due to conflicts (it's usually best to pick
> a really high number and let Eryu mvtest them to their real numbers),
> but these mostly look ok.

Usually the test numbers are not a problem, as long as the patchset is
based on latest master and there's no test number conflicts :)

Overall the tests look fine to me too.

> 
> However, I do see that something isn't triggering an EINVAL return code:

Same results here, tested with xfs/ext4/btrfs on 4.11-rc2 kernel.

And another nitpick is the year in copyright, s/2016/2017/ ?

Thanks,
Eryu
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux