On Fri, Mar 03, 2017 at 03:47:47PM -0500, J. Bruce Fields wrote: > That's what I think too, but then is COPY(2) wrong?: Either the current kernel code or the man page is wrong.. > Also, copy_file_range can be implemented by ->clone_file_range, where > these kinds of checks make more sense, I think; e.g. from btrfs: > > ret = -EINVAL; > if (off + len > src->i_size || off + len < off) > goto out_unlock; > > Well, so the caller just has to be prepared for either behavior, I > guess, but that may make it more complicated to use. We'll need to stick to one behavior. So between the man page and the clone implementation I guess this patch is fine after all. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
