On 22 Feb 2017, at 14:20, Jeff Layton wrote:
Well, that's where their immediate pain point is. If they have
applications that are relying on NLM locking to serialize access to
the
files, then this could potentially corrupt their file data.
It may be that no one would ever notice, but those sorts of bug
reports
can be very difficult to track down. If we can fix this in a way that
works across versions, then that's what I'd suggest.
OK, then it occurs to me that we can do this by passing in a new struct
nlmclnt_operations to nlmclnt_proc(). That can be used to supply a
function
that should be called in rpc_task_prepare to check the iocounter. Then
a
global FL_CLOSE rpc_wait_queue could be used, but I probably wouldn't
want to
wake it on every iocounter reaching zero - probably only if a lock
context
has a flag.. or maybe there's another way to tell.
Those operations would also help further abstract NLM from NFS by adding
functions to extract the rpc_cred from the file, and obtain the file
handle and
owner from the file. Right now, there's some NFS stuff leaking into the
NLM
client.
Ben
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
