Re: [PATCH v2 0/5] Fix "support large inline thresholds"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Feb 1, 2017, at 1:15 PM, Chuck Lever <chuck.lever@xxxxxxxxxx> wrote:
> 
>> 
>> On Jan 24, 2017, at 4:46 PM, Chuck Lever <chuck.lever@xxxxxxxxxx> wrote:
>> 
>>> 
>>> On Jan 24, 2017, at 4:35 PM, Anna Schumaker <Anna.Schumaker@xxxxxxxxxx> wrote:
>>> 
>>> Hi Chuck,
>>> 
>>> On 01/23/2017 03:52 PM, Chuck Lever wrote:
>>>> Hi Anna-
>>>> 
>>>> I've received a number of reports that v4.9 commit 655fec6987be
>>>> ("xprtrdma: Use gathered Send for large inline messages") causes
>>>> NFS/RDMA mounts to fail for devices that have a small max_sge.
>>>> 
>>>> This series addresses that problem. Would you consider this series
>>>> of bug fixes for v4.10-rc?
>>> 
>>> I noticed that patches one and four are the only ones with a "Fixes:" tag.  Do you need all five patches to fix the problem, or can the rest be deferred to 4.11?
>> 
>> 5/5 can be deferred if you want. The others are all required to
>> fix the problem. However, these were tested as a series. I'm
>> reticent to split them at this point.
>> 
>> Should 1 - 4 have a "Fixes: 655fec6987be ("xprtrdma: Use
>> gathered Send for large ...")" ?
> 
> Hi Anna, is there anything more you need from me? As above,
> I was hoping these could be included in v4.10-rc, which is
> likely to be closed in just a week or two.

Hi Anna-

Since I haven't heard from you regarding this series, and v4.10
final is imminent, I will assume these fixes should be folded
into nfs-rdma-for-4.11. v3 of nfs-rdma-for-4.11 will include
these patches.


>>> Thanks,
>>> Anna
>>> 
>>>> 
>>>> 
>>>> Available in the "nfs-rdma-for-4.10-rc" topic branch of this git repo:
>>>> 
>>>> git://git.linux-nfs.org/projects/cel/cel-2.6.git
>>>> 
>>>> And for online review:
>>>> 
>>>> http://git.linux-nfs.org/?p=cel/cel-2.6.git;a=shortlog;h=refs/heads/nfs-rdma-for-4.10-rc
>>>> 
>>>> 
>>>> Changes since v1:
>>>> - Rebased on v4.10-rc5
>>>> - Renamed some variables for clarity
>>>> - Clarified patch descriptions
>>>> - Added Tested-by and Reviewed-by tags
>>>> 
>>>> ---
>>>> 
>>>> Chuck Lever (5):
>>>>    xprtrdma: Fix Read chunk padding
>>>>    xprtrdma: Per-connection pad optimization
>>>>    xprtrdma: Disable pad optimization by default
>>>>    xprtrdma: Reduce required number of send SGEs
>>>>    xprtrdma: Shrink send SGEs array
>>>> 
>>>> 
>>>> net/sunrpc/xprtrdma/rpc_rdma.c  |   62 +++++++++++++++++++++++++--------------
>>>> net/sunrpc/xprtrdma/transport.c |    2 +
>>>> net/sunrpc/xprtrdma/verbs.c     |   15 ++++++---
>>>> net/sunrpc/xprtrdma/xprt_rdma.h |   14 ++++++---
>>>> 4 files changed, 60 insertions(+), 33 deletions(-)
>>>> 
>>>> --
>>>> Chuck Lever
>>>> 
>> 
>> --
>> Chuck Lever
>> 
>> 
>> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> --
> Chuck Lever
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
Chuck Lever



--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux