Re: [PATCH] SUNRPC: Drop all entries left in cache_detail when destroy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kinglong,

[auto build test WARNING on nfsd/nfsd-next]
[also build test WARNING on v4.10-rc6 next-20170203]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Kinglong-Mee/SUNRPC-Drop-all-entries-left-in-cache_detail-when-destroy/20170205-214442
base:   git://linux-nfs.org/~bfields/linux.git nfsd-next
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All warnings (new ones prefixed by >>):

   net/sunrpc/cache.c: In function 'sunrpc_destroy_cache_detail':
>> net/sunrpc/cache.c:372:3: warning: format '%d' expects argument of type 'int', but argument 2 has type 'char *' [-Wformat=]
      printk(KERN_ERR "RPC: %d entries left in %s cache\n", cd->name);
      ^
>> net/sunrpc/cache.c:372:3: warning: format '%s' expects a matching 'char *' argument [-Wformat=]

vim +372 net/sunrpc/cache.c

   356		queue_delayed_work(system_power_efficient_wq, &cache_cleaner, 0);
   357	}
   358	EXPORT_SYMBOL_GPL(sunrpc_init_cache_detail);
   359	
   360	void sunrpc_destroy_cache_detail(struct cache_detail *cd)
   361	{
   362		struct cache_head *ch = NULL;
   363		struct hlist_head *head = NULL;
   364		struct hlist_node *tmp = NULL;
   365		int i = 0;
   366	
   367		cache_purge(cd);
   368		spin_lock(&cache_list_lock);
   369		write_lock(&cd->hash_lock);
   370	
   371		if (cd->entries) {
 > 372			printk(KERN_ERR "RPC: %d entries left in %s cache\n", cd->name);
   373			for (i = 0; i < cd->hash_size; i++) {
   374				head = &cd->hash_table[i];
   375				hlist_for_each_entry_safe(ch, tmp, head, cache_list) {
   376					hlist_del_init(&ch->cache_list);
   377					set_bit(CACHE_CLEANED, &ch->flags);
   378					cache_fresh_unlocked(ch, cd);
   379					cache_put(ch, cd);
   380				}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux