Re: [PATCH v2 2/7] svcrdma: Clean up RPC-over-RDMA Reply header encoder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I'm always confused when a cleanup adds more line than it removes,
but it seems to be just comments in this case and some other
patches in the series.

> + * svc_rdma_xdr_encode_reply_header - Encode Reply's fixed header fields
> + * @rdma: controlling transport
> + * @rdma_argp: Call's transport header
> + * @rdma_resp: Reply's transport header
> + * @rdma_type: procedure number
> + *
> + */
> +void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *rdma,
> +				      __be32 *rdma_argp, __be32 *rdma_resp,
> +				      __be32 rdma_type)

To me it would seem much cleaner to just take the few lines of encoding
into the only caller.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux