On Tue, 31 Jan 2017, NeilBrown wrote: > On Mon, Jan 30 2017, Scott Mayhew wrote: > > > Currently, rpc.mountd's -s/--state-directory-path option doesn't really > > do anything (rpc.mountd tests it via chdir() but that's all). These > > patches implement the -s/--state-directory-path option so that > > rpc.mountd's state files (the etab and rmtab) can be placed in a > > location other than /var/lib/nfs... for example, /run/nfs. > > > > To use /run/nfs, it's necessary to create a systemd-tmpfiles config > > file, e.g. > > > > # cat /usr/lib/tmpfiles.d/nfs.conf > > #Type Path Mode UID GID Age Argument > > d /run/nfs 0755 root root - - > > f /run/nfs/etab 0644 root root - - > > f /run/nfs/rmtab 0644 root root - - > > > > and if selinux is in enforcing mode, the correct context would need to > > be set on the directory (On Fedora, semanage barks at me if I use > > /run/nfs... that's why I'm using /var/run/nfs here instead): > > # semanage fcontext -a -t var_lib_nfs_t /var/run/nfs > > Hi Scott, > thanks for these - I think this is a good improvement. > > I'm not very fond of the term "xtab" used through. > Presumably the intention is that the code is used for "rmtab" and > "etab", so "xtab" matches both, where "x" is the unknown. Yep, that was the idea. > Unfortunately we used to have an "xtab" file, and I keep thinking > of that when I see "xtab". > Maybe "state" ??? or leave it as it is, and I'll get over it. I'll go ahead and change it. > > > > > Notes: > > > > - I didn't actually implement the option (in either the command line or > > the nfs.conf) for exportfs. Instead it reads rpc.mountd's setting from > > the nfs.conf so that they're using the same value. Maybe it would be > > better to add the option to exportfs too and emit a warning if exportfs > > is using a different value than rpc.mountd (which would only be > > detectable if mountd is using the nfs.conf). > > I like your current solution best. > > > - Since the contents of /run are volatile, moving the rmtab file there > > would mean 'showmount -a' would only show NFSv3 mounts that have occurred > > since the last boot. I'm not sure if that's a big deal or not. Looking > > at the rmtab file on my main test server I see a lot of outdated > > entries, so this might actually be preferable. > > I'd be fairly happy to discard rmtab completely. I'll do that in a future patch if nobody objects. > It is, at best, a vague > hint and is, as you observed, often inaccurate. > > > - Looking at rpc.mountd(8) it actually says 'Specify a directory in which > > to place statd state information'... I'm not sure why mountd would care > > where statd puts its state files. The point of these two patches was to > > separate that out, so that all that's left on /var/lib/nfs is the stuff > > used by rpc.statd/sm-notify/nfsdcltrack. I can either use a different > > option or reword that sentence on the man page. > > I think it would be best to reword the man page. As you say, mountd > doesn't care about statd state. Will do. Thanks for looking! -Scott > > Thanks, > NeilBrown > > > > > > > Scott Mayhew (2): > > libnsm.a: refactor nsm_setup_pathnames() and nsm_make_pathname() > > mountd/exportfs: implement the -s/--state-directory-path option > > > > support/export/xtab.c | 82 +++++++++++++++++++++++++++++++++- > > support/include/misc.h | 3 ++ > > support/include/nfslib.h | 17 +++++++ > > support/misc/Makefile.am | 2 +- > > support/misc/file.c | 110 ++++++++++++++++++++++++++++++++++++++++++++++ > > support/nfs/cacheio.c | 4 +- > > support/nfs/rmtab.c | 4 +- > > support/nsm/file.c | 45 ++----------------- > > utils/exportfs/exportfs.c | 13 ++++++ > > utils/mountd/auth.c | 8 ++-- > > utils/mountd/mountd.c | 31 ++++++++----- > > utils/mountd/rmtab.c | 26 ++++++----- > > utils/statd/Makefile.am | 1 + > > 13 files changed, 273 insertions(+), 73 deletions(-) > > create mode 100644 support/misc/file.c > > > > -- > > 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
