Re: [PATCH v2] nfs: Don't increment lock sequence ID after NFS4ERR_MOVED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Jan 26, 2017, at 1:14 PM, Trond Myklebust <trondmy@xxxxxxxxxxxxxxx> wrote:
> 
> On Thu, 2017-01-26 at 13:00 -0500, Chuck Lever wrote:
>> Xuan Qi reports that the Linux NFSv4 client failed to lock a file
>> that was migrated. The steps he observed on the wire:
>> 
>> 1. The client sent a LOCK request to the source server
>> 2. The source server replied NFS4ERR_MOVED
>> 3. The client switched to the destination server
>> 4. The client sent the LOCK request to the destination
>> ย ย ย server with a bumped lock sequence ID
>> 5. The destination server rejected the LOCK request with
>> ย ย ย NFS4ERR_BAD_SEQID
>> 
>> RFC 3530 section 8.1.5 provides a list of NFS errors which do not
>> bump a lock sequence ID.
>> 
>> However, RFC 3530 is now obsoleted by RFC 7530. In RFC 7530 section
>> 9.1.7, this list has been updated by the addition of NFS4ERR_MOVED.
>> 
>> Reported-by: Xuan Qi <xuan.qi@xxxxxxxxxx>
>> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
>> Tested-by: Xuan Qi <xuan.qi@xxxxxxxxxx>
>> Cc: stable@xxxxxxxxxxxxxxx # v3.7+
>> ---
>> Testing confirms this patch addresses the problem that Xuan first
>> observed.
>> 
> 
> Since the first patch was already applied to linux-next, could you
> please make this one incremental?

Is there a stable commit ID for v1 of this patch?

Just wondering if I should include a Fixes: tag in the incremental
patch.


--
Chuck Lever



--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux