Hi Bruce, I've got a report that there NFS clients that send SETATTR requests that mix size changes with uid/gid changes (see the recent pynfs patch for an artifical reproducer). At least XFS and GFS2 are very unhappy with this, and other file systems also don't seem to handle the case correctly. This patch splits the truncate processing in NFS out into a separate ->setattr call and uses the vfs_truncate helper for it, which also happens to shrink the NFSD code size by reusing more VFS boiler plate code. I suspect in the mid-term we really should add a ->truncate method (different from the previous callback of the same name) to separate the two concepts clearly at the VFS level. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html