RE: [PATCH v1 4/5] xprtrdma: Reduce required number of send SGEs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >> +	ia->ri_max_sgeno = max_sge - 3;
> >>
> >
> > I didn't noticed this new ri_max_sgeno variable being used in this patch set.
> Did I miss?
> 
> Yes, you snipped out the other hunk where it is used.

Right. I see it now.
> 
> > You also might want to rename it to ri_max_sge_num.
> > Regardless for some device with 3 SGEs, ri_max_sgeno will become zero. Is
> that fine?
> 
> Yes, that's OK, and tested. Zero means that NFS WRITE and SYMLINK
> payloads will always be sent in a Read chunk.
> 
Ok. Thanks.

> 
> > It would be good to have define for this minimum required 3 SGEs header
> file such as RPCRDMA_MIN_REQ_RECV_SGE.
> 
> OK.
��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux