On Mon, Jan 02, 2017 at 09:40:05AM +0100, Christoph Hellwig wrote: > On Sun, Jan 01, 2017 at 05:10:25PM -0500, Bruce James Fields wrote: > > How do we handle clean shutdown, though? At a minimum a server admin > > needs to be able to e.g. take down the server for an OS upgrade. > > That's going to be a nightmare to implement unfortunately. Ugh. I think it's a requirement; without it: - if we set the flag that allows the client to turn off sillyrename, then users will see a regression (ESTALE after clean shutdowns in situations we previously guaranteed safe). - if we don't set that flag, we don't get to turn off client sillyrename. The only improvement is that we avoid ESTALE after crashes on files unlinked by a different client than held it open. I don't think that's very interesting on its own. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html