On Fri, Dec 23, 2016 at 09:32:25AM +0800, Kinglong Mee wrote: > Signed-off-by: Kinglong Mee <kinglongmee@xxxxxxxxx> > --- > fs/nfsd/nfs3proc.c | 2 +- > fs/nfsd/nfsproc.c | 2 +- > fs/nfsd/vfs.c | 35 +++++++++++------------------------ > fs/nfsd/vfs.h | 4 ++-- > 4 files changed, 15 insertions(+), 28 deletions(-) > > diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c > index 69cd0f1..ec7a63f 100644 > --- a/fs/nfsd/nfs3proc.c > +++ b/fs/nfsd/nfs3proc.c > @@ -193,7 +193,7 @@ nfsd3_proc_write(struct svc_rqst *rqstp, struct nfsd3_writeargs *argp, > > fh_copy(&resp->fh, &argp->fh); > resp->committed = argp->stable; > - nfserr = nfsd_write(rqstp, &resp->fh, NULL, > + nfserr = nfsd_write(rqstp, &resp->fh, > argp->offset, > rqstp->rq_vec, argp->vlen, > &cnt, Maybe move one or two args up (and use normal two-tab line continuations) to make this a bit more readable? > diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c > index f157c7e..45ca598 100644 > --- a/fs/nfsd/nfsproc.c > +++ b/fs/nfsd/nfsproc.c > @@ -210,7 +210,7 @@ nfsd_proc_write(struct svc_rqst *rqstp, struct nfsd_writeargs *argp, > SVCFH_fmt(&argp->fh), > argp->len, argp->offset); > > - nfserr = nfsd_write(rqstp, fh_copy(&resp->fh, &argp->fh), NULL, > + nfserr = nfsd_write(rqstp, fh_copy(&resp->fh, &argp->fh), > argp->offset, > rqstp->rq_vec, argp->vlen, > &cnt, Same here? Otherwise this looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
